[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

MaskRay added a comment. I pushed 0ba43f4c2b263268f6fbc56bb3f6d43936781957 with an elaborated comment. This patch is not needed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew added a comment. I'll leave it to someone else to get non-FreeBSD working as it's unlikely I'll have time to fix them in the hear future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 __

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew updated this revision to Diff 436338. andrew added a comment. Update the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Dri

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

brad added a comment. I was just looking at the same diff for OpenBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127393/new/ https://reviews.llvm.org/D127393 ___ cfe-commits mailing list cfe-commits@

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

MaskRay accepted this revision. MaskRay added a comment. Perhaps change to `isOSLinux() && isGNUEnvironment()` now. I suspect other *BSD don't need this, either. musl definitely doesn't need this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12739

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

kda accepted this revision. kda added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:841 CmdArgs.push_back("-lexecinfo"); // There is no libresolv on Android. + if (!TC.getTriple().isAndroid() && !

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

andrew created this revision. andrew added reviewers: kda, vitalybuka, eugenis, MaskRay. Herald added subscribers: StephenFan, krytarowski, arichardson, emaste. Herald added a project: All. andrew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi