[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35aaf548237a: [clang][driver] fix to correctly set devtoolset on RHEL (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 _

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp added a comment. Thanks @tbaeder, @MaskRay, and @nemanjai. > I did not remove that on purpose, so adding it back makes sense to me. I've updated the patch to remove the path without the `/root/usr` suffix and exclusively add the path with the `root/usr` suffix. > This change also needs

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435914. quinnp added a comment. Herald added a subscriber: ormris. Addressing review comments. Removing path without `/root/usr` prefix and changing unit test to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

tbaeder added a comment. In D127310#3568777 , @nemanjai wrote: > In D127310#3567472 , @MaskRay wrote: > >> Do you have more authoritative answer when /root/usr is used and when it >> isn't? > > These suffixes wer

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

nemanjai added a comment. In D127310#3567472 , @MaskRay wrote: > Do you have more authoritative answer when /root/usr is used and when it > isn't? These suffixes were always part of the code and the mentioned changeset removed it without any justificat

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

MaskRay added a comment. Do you have more authoritative answer when /root/usr is used and when it isn't? I'd wish that we have comments for them. This change also needs a unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https:/

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp marked 2 inline comments as done. quinnp added a comment. Thank you @nemanjai! I've updated the patch based on your suggestion and tested it for both the existing testcase and the RHEL buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435239. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

nemanjai added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2152 ChosenToolsetVersion = ToolsetVersion; -ChosenToolsetDir = "/opt/rh/" + ToolsetDir.str(); +ChosenToolsetDir = "/opt/rh/" + ToolsetDir.str() + "/root/usr"; } --

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch correctly sets the devtoolset on RHEL. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1