mgehre-amd closed this revision.
mgehre-amd added a comment.
Merged
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127287/new/
https://reviews.llvm.org/D127287
___
cfe-commits mailing list
cfe-commits@lis
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Comment at: clang/test/Sema/large-bit-int.c:1
+// RUN: %clang_cc1 -fexperimental-max-bitint-width=1024 -fsyntax-only -verify
%s -Wno-unused -t
mgehre-amd added a comment.
Thanks for the quick review!
Comment at: clang/test/Sema/large-bit-int.c:1
+// RUN: %clang_cc1 -fexperimental-max-bitint-width=1024 -fsyntax-only -verify
%s -Wno-unused -triple x86_64-gnu-linux
+
aaron.ballman wrote:
> Thoughts on a
mgehre-amd updated this revision to Diff 435161.
mgehre-amd marked 4 inline comments as done.
mgehre-amd added a comment.
Used Optional
Added entry to release notes
Modifed help text according to suggestion
Added comment to LANGOPT that it will be removed in the future
Repository:
rG LLVM Gith
aaron.ballman added a comment.
Given that this is a hidden option we expect to remove... do we add a release
note for it? I think we probably should (for user awareness in case more users
are in the same situation as the original reporter), and that gives a place to
document that we will be rem
mgehre-amd created this revision.
mgehre-amd added a reviewer: aaron.ballman.
Herald added a project: All.
mgehre-amd requested review of this revision.
Herald added a project: clang.
This splits of the introduction of -fexperimental-max-bitint-width
from https://reviews.llvm.org/D122234
because
