[PATCH] D127201: [clang] Add tests for statement expression in initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG657e954939c8: [clang] Add tests for statement expression in initializers (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127201: [clang] Add tests for statement expression in initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! (The precommit CI failures appear to be unrelated to the changes in this patch.) Thanks for the additional test coverage! Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders updated this revision to Diff 436561. wanders added a subscriber: kimgr. wanders added a comment. Updated diff with: - Release note - Cleaned up command line options in RUN commands - Fixed type mimatch pointed out by @kimgr (out of band) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders added a comment. In D127201#3578077 , @aaron.ballman wrote: > Thanks for adding some more test coverage! Would it be worth mentioning the > miscompile fix in the release notes more explicitly? Yes, might be a good idea, in particualar as some c

[PATCH] D127201: [clang] Add tests for statement expression in initializers

aaron.ballman added a comment. Thanks for adding some more test coverage! Would it be worth mentioning the miscompile fix in the release notes more explicitly? Comment at: clang/test/Sema/stmtexpr-init.c:1 +// RUN: %clang_cc1 -verify -fsyntax-only -std=gnu11 %s + -

[PATCH] D127201: [clang] Add tests for statement expression in initializers

erichkeane added a comment. The command line on one of the tests is a little strange to me, and I don't see the need for the -std=gnu11 on either, but the test content itself looks fine enough to me. Comment at: clang/test/CodeGen/stmtexpr-init.c:1 +// RUN: %clang_cc1 -O -std

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders added a comment. One week gentle ping. + added reviewers from the https://reviews.llvm.org/D111400 patch that fixed the bug these tests covers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127201/new/ https://reviews.llvm.org/D127201 ___

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders created this revision. wanders added reviewers: cor3ntin, rsmith. wanders added a project: clang. Herald added a project: All. wanders requested review of this revision. Herald added a subscriber: cfe-commits. The commit 683e83c5