[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D127187#3650824 , @iains wrote: > Hi @ChuanqiXu, > I have no comment on the technical content of the patch (it looks reasonable > to me). > > However, I wonder if we should be supplying th

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

iains added a comment. Hi @ChuanqiXu, I have no comment on the technical content of the patch (it looks reasonable to me). However, I wonder if we should be supplying this option at all because in: https://eel.is/c++draft/module#reach-2 note2 says "[Note 2: It is advisable to avoid depending on

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. @iains @rsmith @MaskRay gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. The direction is approved in https://reviews.llvm.org/D113545. @MaskRay might you help to review the style? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___ cfe-commits

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu updated this revision to Diff 440872. ChuanqiXu added a reviewer: MaskRay. ChuanqiXu added a comment. Herald added a subscriber: StephenFan. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 Files: clang/include/clang/Basic

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, rsmith, clang-language-wg. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. [modu