[PATCH] D127145: [Driver] add -lresolv for all but Android.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dce56b2a308: [Driver] add -lresolv for all but Android. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda updated this revision to Diff 434634. kda marked an inline comment as done. kda added a comment. removed braces on single statement from conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 Fil

[PATCH] D127145: [Driver] add -lresolv for all but Android.

eugenis accepted this revision. eugenis added a comment. Typo: "runttime" LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 ___ cfe-commits mailing list cfe

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda added a comment. In D127145#3561519 , @eugenis wrote: > The interceptor (dn_expand) is only defined on linux && !android, while this > code links libresolv on *bsd and others, too. I think it's ok, as long as all > platforms with the interceptor are

[PATCH] D127145: [Driver] add -lresolv for all but Android.

eugenis added a comment. The interceptor (dn_expand) is only defined on linux && !android, while this code links libresolv on *bsd and others, too. I think it's ok, as long as all platforms with the interceptor are covered. It would be great to mention the actual reason we do this in the commit

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:843 + if (!TC.getTriple().isAndroid()) { +CmdArgs.push_back("-lresolv

[PATCH] D127145: [Driver] add -lresolv for all but Android.

vitalybuka added a comment. yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc. I guess if make mistake it will be noticed and fixed. Please update clang/test/Driver/sanitizer-ld.c Repository: rG LLVM Gi

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay added a comment. The description needs to mention the motivation. Is this meant for `isOSLinux() && isGNUEnvironment()` targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 __

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda created this revision. kda added reviewers: vitalybuka, eugenis. Herald added subscribers: Enna1, danielkiss. Herald added a project: All. kda requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers. Repository: