[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

This revision was automatically updated to reflect the committed changes. Closed by commit rG52818fd97f0f: [Clang][FP16] Add 4 builtins for _Float16 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127050/new/ https://reviews.llv

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + LuoYuanke wrote: > pengfei wrote: > > LuoYuanke wrote: > > > Is _Float16 a legal type for target armv7a and aarch64?

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + pengfei wrote: > LuoYuanke wrote: > > Is _Float16 a legal type for target armv7a and aarch64? > Yes, see > https:/

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + LuoYuanke wrote: > Is _Float16 a legal type for target armv7a and aarch64? Yes, see https://clang.llvm.org/docs/Lang

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + Is _Float16 a legal type for target armv7a and aarch64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:145 BUILTIN(__builtin_huge_vall, "Ld", "nc") +BUILTIN(__builtin_huge_valf16, "x", "nc") BUILTIN(__builtin_huge_valf128, "LLd", "nc") LuoYuanke wrote: > Is the builtin sorted in al

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:145 BUILTIN(__builtin_huge_vall, "Ld", "nc") +BUILTIN(__builtin_huge_valf16, "x", "nc") BUILTIN(__builtin_huge_valf128, "LLd", "nc") Is the builtin sorted in alphabet order? R

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei created this revision. pengfei added reviewers: rjmccall, erichkeane, LuoYuanke. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are lacking builtins support for `_Float16`. In most cases, we