[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3247bf9f71: [tbaa] Handle base classes in struct tbaa (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 _

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441294. brunodf added a comment. Adding comment regarding empty subobjects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 Files: clang/lib/CodeGen/CodeGenTBAA.cpp

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:366 + // so may differ from declaration order. In particular, Itanium ABI will + // allocate a primary base first. + llvm::sort(Fields, Maybe add a comment explaining why

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf updated this revision to Diff 441017. brunodf added a comment. Herald added a subscriber: mgrang. New version that fixes the problem with base classes not appearing in order of increasing offset. This issue was discovered in the multistage build, but the test case has now been extended

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere added a comment. In D126956#3604978 , @fhahn wrote: > Please take a look and revert the patch if the fix isn't trivial. the patch has already been reverted so Bruno can investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

fhahn added a comment. It looks like this commit is breaking bootstrap builds of LLVM/Clang, e.g. https://lab.llvm.org/buildbot/#/builders/37/builds/14224 FAILED: lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o /b/sanitizer-x86_64-linux-autoconf/build/tsan_debug_build/bi

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdc59e2202c1: [tbaa] Handle base classes in struct tbaa (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 _

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf added a comment. Anyone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126956/new/ https://reviews.llvm.org/D126956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

brunodf created this revision. brunodf added reviewers: jeroen.dobbelaere, eli.friedman. Herald added a subscriber: kosarev. Herald added a project: All. brunodf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a fix for the miscompi