[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D126937#3555731 , @aaron.ballman wrote: > In D126937#3555243 , @browneee > wrote: > >> I was also looking into fixing this: https://reviews.llvm.org/D126944 >> >> I'm not yet su

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D126937#3555243 , @browneee wrote: > I was also looking into fixing this: https://reviews.llvm.org/D126944 > > I'm not yet sure if my changes are correct. I did a review on https://reviews.llvm.org/D126944, but I'll let

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Andrew via Phabricator via cfe-commits
browneee added a comment. I was also looking into fixing this: https://reviews.llvm.org/D126944 I'm not yet sure if my changes are correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937 ___

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok planned changes to this revision. MitalAshok added a comment. Appears that more things need to be changed, I'll get that done soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126937/new/ https://reviews.llvm.org/D126937 __

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:5561 Var = cast_or_null(Instantiator.VisitVarTemplateSpecializationDecl( VarSpec->getSpecializedTemplate(), Def, VarSpec->getTemplateArgsInfo(), VarSpec->getTempla

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

2022-06-02 Thread Mital Ashok via Phabricator via cfe-commits
MitalAshok created this revision. Herald added a project: All. MitalAshok added reviewers: akyrtzi, aaron.ballman, erichkeane, browneee. MitalAshok published this revision for review. MitalAshok added a project: LLVM. MitalAshok added a comment. Herald added a project: clang. Herald added a subscri