[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb784db4961: [clang] [MinGW] Default to WinEH (SEH) exception handling instead of Dwarf (authored by mstorsjo). Changed prior to commit: https://

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Funclets are necessary for both C++ and SEH exception handling, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___ cfe-commits m

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D126871#3561243 , @efriedma wrote: >> But for MSVC style (C++ exceptions and __try/__except) there's still a >> couple backend things that need to be implemented. Do you happen to know >> roughly how much effort that is? > >

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Btw, thanks a lot for your reviews, you've spent a lot of time on them! You're welcome. > But for MSVC style (C++ exceptions and __try/__except) there's still a couple > backend things that need to be implemented. Do you happen to know roughly how > much effort that

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D126871#3560924 , @efriedma wrote: > Oh, just remembered, we should probably release-note this. (You can post > that as a followup.) Sure, can do. Btw, thanks a lot for your reviews, you've spent a lot of time on them! The

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Oh, just remembered, we should probably release-note this. (You can post that as a followup.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 __

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

2022-06-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: efriedma, zzheng. Herald added a subscriber: kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. This goes hand in hand with D126870