This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe8402d5de82a: [clang] [MSVC] Enable unwind tables for ARM
(authored by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
MaskRay added a comment.
(I still think it helps to drop some RUN lines from pic.c but that change can
be separate.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126862/new/
https://reviews.llvm.org/D126862
__
MaskRay accepted this revision.
MaskRay added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126862/new/
https://reviews.llvm.org/D126862
___
cfe-commits mailing list
cfe-commits@lists.ll
mstorsjo updated this revision to Diff 433836.
mstorsjo added a comment.
Added testing, including testing for the existing architectures.
There was a good match for testing for this in windows-exceptions.cpp -
unfortunately it ends up with 2 more RUN lines, but it fits in so well there so
I'd r
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.
This needs a test. There is existing testing gap as this change does not break
any clang/test/Driver test.
@@ -449,13 +449,15 @@ bool MSVCToolChain::
mstorsjo created this revision.
mstorsjo added reviewers: efriedma, zzheng.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a subscriber: MaskRay.
Herald added a project: clang.
The backend now can generate working unw
