[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 updated this revision to Diff 439004. njames93 added a comment. Remove typo correction support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126859/new/ https://reviews.llvm.org/D126859 Files: clang-tools-extra/clangd/ConfigCompile.cpp

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 added a comment. In D126859#3599340 , @kadircet wrote: > I also agree with the typo correction verdict. In theory there'll be two > cases: > > - typo correction helps, in which case it'll be obvious from the warning > itself. > - typo correcti

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

kadircet added a comment. I also agree with the typo correction verdict. In theory there'll be two cases: - typo correction helps, in which case it'll be obvious from the warning itself. - typo correction doesn't help, because the option doesn't exist at all, we'll be just showing a random opt

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

sammccall added a comment. FWIW, I think validating the names makes sense but I don't think typo correction pays for itself here. @kadircet? Comment at: clang-tools-extra/clangd/TidyProvider.cpp:291 + static void *call() { +return new tidy::NamesAndOptions(tidy::getAllChe

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 updated this revision to Diff 438388. njames93 added a comment. Reuse implementation from D127446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126859/new/ https://reviews.llvm.org/D126859 Files: clang

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 planned changes to this revision. njames93 added a comment. Gonna wait for the infrastructure from D127446 to land first, can reuse most of that implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e