[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-10 Thread Christopher Di Bella via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf21187eb2d94: [clang][tablegen] adds human documentation to `WarningOption` (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. > Good question. Unless this functionality already has tests (and I'm gathering > it doesn't), I think we can rely on Clang being the test. (Though we should > consider ourselves

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-08 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D126832#3567035 , @aaron.ballman wrote: > In D126832#3554816 , @cjdb wrote: > >> In D126832#3553569 , >> @aaron.ballman wrote: >> >>> Can you po

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-08 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 435255. cjdb marked 2 inline comments as done. cjdb added a comment. applies feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126832/new/ https://reviews.llvm.org/D126832 Files: clang/include/clang/Basic/

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-08 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D126832#3554816 , @cjdb wrote: > In D126832#3553569 , @aaron.ballman > wrote: > >> Can you post some examples of the output from this option so we can see what >> the end result

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-02 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb added a comment. In D126832#3553569 , @aaron.ballman wrote: > Can you post some examples of the output from this option so we can see what > the end results look like more easily? Right now this doesn't do anything at all, except feed the document

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Can you post some examples of the output from this option so we can see what the end results look like more easily? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126832/new/ https://reviews.llvm.org/D126832

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

2022-06-01 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building on D126796