tra added inline comments.
Comment at: llvm/lib/Object/OffloadBinary.cpp:18
-
-namespace llvm {
MaskRay wrote:
> tra wrote:
> > tra wrote:
> > > Nit: `using namespace` seems a bit too heavy-handed when you only need
> > > one enum
> > > `using object_error = l
MaskRay added inline comments.
Comment at: llvm/lib/Object/OffloadBinary.cpp:18
-
-namespace llvm {
tra wrote:
> tra wrote:
> > Nit: `using namespace` seems a bit too heavy-handed when you only need one
> > enum
> > `using object_error = llvm::object::object_e
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGafd2f7e99197: [Binary] Promote OffloadBinary to inherit from
Binary (authored by jhuber6).
Changed prior to commit:
https://reviews.llvm.org/D1268
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Object/OffloadBinary.cpp:28
+ if (identify_magic(Buf.getBuffer()) != file_magic::offload_binary)
return errorCodeToError(llvm::object::object_error::
jhuber6 updated this revision to Diff 433534.
jhuber6 added a comment.
Addressing comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126812/new/
https://reviews.llvm.org/D126812
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm/include/llvm-c
jhuber6 added a comment.
Thanks for the comments, I'll address them real quick.
Comment at: llvm/include/llvm/Object/OffloadBinary.h:121
const Entry *TheEntry)
- : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) {
-
+ : Binary(Binary::ID_Offl
tra added a comment.
LGTM in principle, with new nits.
Comment at: llvm/include/llvm/Object/OffloadBinary.h:121
const Entry *TheEntry)
- : Buffer(Buffer), TheHeader(TheHeader), TheEntry(TheEntry) {
-
+ : Binary(Binary::ID_Offload, Source), Buffer(Sour
jhuber6 updated this revision to Diff 433504.
jhuber6 added a comment.
Fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126812/new/
https://reviews.llvm.org/D126812
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm/include/llvm-c/Object.h
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, MaskRay.
Herald added a reviewer: deadalnix.
Herald added subscribers: ormris, StephenFan, hiraditya.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: llvm-commi
