Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Ted Kremenek via cfe-commits
krememek accepted this revision. krememek added a comment. This revision is now accepted and ready to land. Committed in r246978. http://reviews.llvm.org/D12673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Ted Kremenek via cfe-commits
krememek added a comment. I am OK with taking these changes. For those using git, git blame -w should suffice to show the real blame history. http://reviews.llvm.org/D12673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Honggyu Kim via cfe-commits
honggyu.kim added a comment. In http://reviews.llvm.org/D12673#241100, @dblaikie wrote: > We generally don't do large whitespace changes like this because of issue > with version control (not all told are whitespace ignorant which makes > history work difficult). I agree that it would be diff

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread David Blaikie via cfe-commits
dblaikie added a subscriber: dblaikie. dblaikie added a comment. We generally don't do large whitespace changes like this because of issue with version control (not all told are whitespace ignorant which makes history work difficult). I don't mind these changes personally, but it should get sign

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread David Blaikie via cfe-commits
We generally don't do large whitespace changes like this because of issue with version control (not all told are whitespace ignorant which makes history work difficult). I don't mind these changes personally, but it should get sign of from Ted or similar first. On Sep 7, 2015 5:47 AM, "Honggyu Kim

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Honggyu Kim via cfe-commits
honggyu.kim added a comment. In http://reviews.llvm.org/D12673#240933, @sylvestre.ledru wrote: > Note: I am not the owner of this code but to me, this should be committed > without a review. I don't have commit permission, so please anyone commit it instead of me. http://reviews.llvm.org/D12

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. Note: I am not the owner of this code but to me, this should be committed without a review. http://reviews.llvm.org/D12673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D12673: [analyzer] Remove whitespace in source code

2015-09-07 Thread Honggyu Kim via cfe-commits
honggyu.kim added a comment. If anyone thinks this patch is too big, I can submit smaller separated patches. http://reviews.llvm.org/D12673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co