Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread don hinton via cfe-commits
hintonda added a comment. In http://reviews.llvm.org/D12646#241493, @bob.wilson wrote: > On Darwin platforms, the libc++ headers are expected to be installed > alongside clang. If you're not doing that, then you're building it wrong. > Adding more fallback options for finding the headers just m

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread Bob Wilson via cfe-commits
bob.wilson added a comment. On Darwin platforms, the libc++ headers are expected to be installed alongside clang. If you're not doing that, then you're building it wrong. Adding more fallback options for finding the headers just makes things worse, because instead of a clear failure, you're mor

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread Nico Weber via cfe-commits
thakis added a comment. In http://reviews.llvm.org/D12646#241318, @hintonda wrote: > In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote: > > > In what scenario exactly are you seeing an issue? If it's a just-built > > clang that can't find C++ headers, then you should just build the li

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread don hinton via cfe-commits
hintonda added a comment. > I think it works if you a) check out libcxx into llvm/projects/libcxx b) run > `make install` and c) run the binary from your install directory. Yes, that works. But why shouldn't users be able to use the installed version? Also, if you want to force users to eithe

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread Kuba Brecka via cfe-commits
kubabrecka added a comment. > > I first noticed it when I tried to run the version of clang-tidy I'd just > > built and found I had to pass the path for it to find iostream. > > > I think it works if you a) check out libcxx into llvm/projects/libcxx b) run > `make install` and c) run the bi

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread don hinton via cfe-commits
hintonda added a comment. In http://reviews.llvm.org/D12646#241308, @kubabrecka wrote: > In what scenario exactly are you seeing an issue? If it's a just-built clang > that can't find C++ headers, then you should just build the libcxx project > alongside. clang++ defaults to -stdlib=libc++ f

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-08 Thread Kuba Brecka via cfe-commits
kubabrecka added a comment. In what scenario exactly are you seeing an issue? If it's a just-built clang that can't find C++ headers, then you should just build the libcxx project alongside. Comment at: lib/Driver/ToolChains.cpp:290-295 @@ +289,8 @@ + + // FIXME: We shou

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-07 Thread don hinton via cfe-commits
Not sure why arc removed some reviewers when I added the latest diff, but I've added them back. Sorry for the noise... On Mon, Sep 7, 2015 at 8:36 PM, don hinton wrote: > hintonda updated this revision to Diff 34175. > hintonda removed reviewers: thakis, EricWF, kubabrecka. > hintonda added a c

Re: [PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-07 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 34175. hintonda removed reviewers: thakis, EricWF, kubabrecka. hintonda added a comment. Removed redundant code from InitHeaderSearch.cpp, it's handled more cleanly in AddClangCXXStdlibIncludeArgs. Also, newer versions of OSX add libc++ as the default. Per

[PATCH] D12646: Add libc++ header path for DarwinClang builds

2015-09-04 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: rsmith. hintonda added a subscriber: cfe-commits. Current behavior doesn't add c++ header path if libc++ wasn't installed via macports in /usr. This change will try to locate c++ headers from various locations, including in tree, via ma