[PATCH] D12644: Using -isysroot on Apple platform

2017-01-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. I'm resigning as a reviewer. I suggested an alternative fix and explained why this fix wasn't correct in a comment above. Please re-add me as a reviewer if you disagree with my analysis. https://revi

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-10-06 Thread Eric Fiselier via cfe-commits
EricWF added a comment. You need to use the CMake option `CMAKE_OSX_SYSROOT` to manage the system root because `lib/CMakeLists.txt` uses "CMAKE_OSX_SYSROOT" to find the correct libc++abi.dylib. Have you tried that? It is unfortunate that Linux and OS X use different options for the same thing t

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-08 Thread Joerg Sonnenberger via cfe-commits
On Mon, Sep 07, 2015 at 11:50:55PM +, Eric Fiselier via cfe-commits wrote: > EricWF added a comment. > > Why would we not use "-isysroot" on other platforms as well? Because otherwise you can't link in a cross-compiling setup? Joerg ___ cfe-commits

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-07 Thread Steven Wu via cfe-commits
steven_wu added a comment. That works as well. I am not sure if there is any specific reason for using "--sysroot" so I proposed a safer fix. http://reviews.llvm.org/D12644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-07 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Why would we not use "-isysroot" on other platforms as well? http://reviews.llvm.org/D12644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Steven Wu via cfe-commits
steven_wu updated this revision to Diff 34073. steven_wu added a comment. Sorry, made a typo on the previous patch. A little background information. When the greendragon jenkins make an system upgrade in the future, it will need this flag as well to build and test libcxx through cmake/ninja. ht

Re: [PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Eric Fiselier via cfe-commits
EricWF added a reviewer: danalbert. EricWF added a subscriber: danalbert. EricWF added a comment. @danalbert actually uses this option. I would like him to confirm this change. http://reviews.llvm.org/D12644 ___ cfe-commits mailing list cfe-commits@

[PATCH] D12644: Using -isysroot on Apple platform

2015-09-04 Thread Steven Wu via cfe-commits
steven_wu created this revision. steven_wu added a reviewer: EricWF. steven_wu added a subscriber: cfe-commits. --sysroot might cause inconsistency between the header gets used and the library gets linked on Apple platform. Use -isysroot instead. http://reviews.llvm.org/D12644 Files: CMakeList