c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126377/new/
https://reviews.llvm.org/D126377
___
c-rhodes added inline comments.
Comment at: clang/test/Sema/aarch64-sve-vector-arith-ops.c:23
- (void)(i8 + f64); // expected-error{{invalid operands to binary expression}}
- (void)(i8 + 0); // expected-error{{invalid operands to binary expression}}
- (void)(i8 + 0l); // ex
DavidTruby added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:10614
+ (!RHSType->isVLSTBuiltinType() && !RHSType->isRealType())) {
+Diag(Loc, diag::err_typecheck_vector_not_convertable_non_scalar)
+<< LHSType << RHSType << LHS.get()->getSourceRange()
DavidTruby added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:10609-10614
- if (RHSType->isVLSTBuiltinType() && !LHSType->isVLSTBuiltinType()) {
-auto DestType = tryScalableVectorConvert((IsCompAssign ? nullptr : &LHS),
-
c-rhodes added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:10609-10614
- if (RHSType->isVLSTBuiltinType() && !LHSType->isVLSTBuiltinType()) {
-auto DestType = tryScalableVectorConvert((IsCompAssign ? nullptr : &LHS),
-
