This revision was automatically updated to reflect the committed changes.
Closed by commit rG5bf44aa434ff: [clang-format][NFC] Refactor
UnwrappedLineParser::parseBlock() (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126358/new/
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874
- if (SimpleBlock && !KeepBraces) {
+ auto RemoveBraces = [=]() mutable {
+if (KeepBraces || !Simpl
owenpan added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874
- if (SimpleBlock && !KeepBraces) {
+ auto RemoveBraces = [=]() mutable {
+if (KeepBraces || !SimpleBlock)
curdeius wrote:
> Are there many captures here? Wouldn't it
curdeius added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874
- if (SimpleBlock && !KeepBraces) {
+ auto RemoveBraces = [=]() mutable {
+if (KeepBraces || !SimpleBlock)
Are there many captures here? Wouldn't it be better to be e
owenpan created this revision.
owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay.
owenpan added a project: clang-format.
Herald added a project: All.
owenpan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
