[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty marked an inline comment as done. daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty updated this revision to Diff 435609. daltenty added a comment. - Don't try to export internal linkage RTTI types - Make shouldMapVisibilityToDLLExport inline and provide a short-circuit evaluation in the case where no mapping is in effect. This should hopefully solve the compile time i

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((D->hasAttr() || + shouldMapVisi

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

thakis added a comment. When you reland this, please reland 4463bd0f89181234e0cef982e21de2e96038f873 at the same time. Else, this breaks tests in some build configurations. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

hans added a comment. We're hitting an assertion in Chromium due to this: llvm/clang/lib/AST/Decl.cpp:1510: clang::LinkageInfo clang::LinkageComputer::getLVForDecl(const clang::NamedDecl *, clang::LVComputationKind): Assertion `D->getCachedLinkage() == LV.getLinkage()' failed. See https://b

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty added a comment. In D126340#3552645 , @nikic wrote: > It looks like this causes a major compile-time regression in the clang > frontend: > http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a267

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

nikic added a comment. It looks like this causes a major compile-time regression in the clang frontend: http://llvm-compile-time-tracker.com/compare.php?from=6232a8f3d61e5856c17e7b314385e9ea8068cdc1&to=8c8a2679a20f621994fa904bcfc68775e7345edc&stat=instructions For example, tramp3d-v4 is up 5% i

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c8a2679a20f: [clang][AIX] add option mdefault-visibility-export-mapping (authored by daltenty). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep