This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG48ca3a5ebb15: [OpenMP] Extend omp teams to permit nested omp
atomic (authored by jdenny).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
jdenny marked 2 inline comments as done.
jdenny added a comment.
Thanks. Will try to push tomorrow.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126323/new/
https://reviews.llvm.org/D126323
___
cfe-commits mailing list
cfe-commits@lists.llv
jdenny updated this revision to Diff 431804.
jdenny added a comment.
Fixed a bug in the new tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126323/new/
https://reviews.llvm.org/D126323
Files:
clang/lib/Sema/SemaOpenMP.cpp
clang/test/OpenMP/nesting_of_regions.cpp
openmp/libom
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LY
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126323/new/
https://reviews.llvm.org/D126323
___
jdenny added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983
+ CurrentRegion != OMPD_loop &&
+ !(SemaRef.getLangOpts().OpenMPExtensions &&
+CurrentRegion == OMPD_atomic);
---
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983
+ CurrentRegion != OMPD_loop &&
+ !(SemaRef.getLangOpts().OpenMPExtensions &&
+CurrentRegion == OMPD_atomic);
--
jdenny added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983
+ CurrentRegion != OMPD_loop &&
+ !(SemaRef.getLangOpts().OpenMPExtensions &&
+CurrentRegion == OMPD_atomic);
---
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4983
+ CurrentRegion != OMPD_loop &&
+ !(SemaRef.getLangOpts().OpenMPExtensions &&
+CurrentRegion == OMPD_atomic);
--
jdenny created this revision.
jdenny added reviewers: jdoerfert, ABataev.
jdenny added a project: OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
jdenny requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang
