[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe917801eddbe: [Clang][Driver] Fix include paths for `--sysroot /` on Linux (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432568. egorzhdan marked an inline comment as done. egorzhdan added a comment. Rebase & fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files: clan

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan marked 2 inline comments as done. egorzhdan added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string &Path, + const Twine &A, const Twine &B, -

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432539. egorzhdan added a comment. - Change arg type from `std::string` to `StringRef` - Remove unnecessary `//` • Remove unneeded test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://revie

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string &Path, + const Twin

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432256. egorzhdan added a comment. - Remove unnecessary trailing `/` - Add `-SAME` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files: clang/include/c

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string &Path, const Twine &A, +const Twine &B = "", const Twine &C = "", egorzhdan wrote: > MaskRay wrote:

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string &Path, const Twine &A, +const Twine &B = "", const Twine &C = "", MaskRay wrote: > This can use `l

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:219 + + static std::string concat(const std::string &Path, const Twine &A, +const Twine &B = "", const Twine &C = "", This can use `llvm::sys::path::app

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan created this revision. Herald added subscribers: pmatos, asb, jgravelle-google, sbc100, dschuff. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, aheejin. Herald added a project: clang. Currently if `--sysroot /` is