[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-25 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf75bc5bfc8f8: [analyzer] Fix symbol simplification assertion failure (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/test/Analysis/symbol-simplification-assertion.c:27 + assert(a + L1 + 1 + b != c); + assert(a == 0); // no-assertion +} steakhal wrote: > Is this statement still reachable? Demonstrate it by using the > `clang_an

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 431635. martong marked an inline comment as done. martong added a comment. - Add clang_analyzer_warnIfReached() to the test and remove unused debug function decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D126281#3533755 , @martong wrote: >> Point 2) above has negligible performance impact, empirical measurements do >> not show any noticeable difference in the run-time. > > Attaching the measurement results that show the run-t

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. > Point 2) above has negligible performance impact, empirical measurements do > not show any noticeable difference in the run-time. Attaching the measurement results that show the run-time difference is not noticeable, or rather it is within the margin of error. F23176

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/test/Analysis/symbol-simplification-assertion.c:15-18 +void clang_analyzer_printState(); +void clang_analyzer_dump(long); +void clang_analyzer_eval(int); + TODO remove. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

2022-05-24 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: