This revision was automatically updated to reflect the committed changes.
Closed by commit rL247423: [Static Analyzer] Minor cleanups for the nullability
checker. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12619?vs=34458&id=34553#toc
Repository:
rL LLVM
http://re
xazax.hun updated this revision to Diff 34458.
xazax.hun added a comment.
- Updated to latest trunk
- Reworded the diagnostic messages
http://reviews.llvm.org/D12619
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
Index: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp
==
danielmarjamaki added a subscriber: danielmarjamaki.
danielmarjamaki added a comment.
Overall.. LGTM
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:78
@@ -78,2 +77,3 @@
+ llvm_unreachable("Unexpected enumeration.");
return "";
}
After llvm_u
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:99
@@ +98,3 @@
+ "Nullable pointer is assigned to a "
+ "pointer which has _Nonnull type",
+
xazax.hun added a comment.
They are in the anonymous namespace. Maybe it would be cleaner to move them
outside of the namespace and preserve the static keyword?
http://reviews.llvm.org/D12619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Why static was removed from getMostNullable() and getNullabilityString()? If
these functions are not intended to be used outside this source file, it's good
idea to limit their scope. Same should be done for Error
xazax.hun created this revision.
xazax.hun added reviewers: dcoughlin, zaks.anna.
xazax.hun added a subscriber: cfe-commits.
This patch contains minor cleanups and style fixes for the nullability checker.
NFC.
http://reviews.llvm.org/D12619
Files:
lib/StaticAnalyzer/Checkers/NullabilityChecke
