rjmccall added a comment.
I'm sorry for the delay. It looks fine, thanks.
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
Is anyone feeling responsible for a final go / review? It would be great for
our research project to have at least basic offloading support in 3.8...
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Are there any more comments for this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Any more comments on this patch?
Thanks!
Samuel
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 40992.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/Driver/CC1Options.td
include/clang/Drive
sfantao added a comment.
Ping!
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
In http://reviews.llvm.org/D12614#284158, @sfantao wrote:
> As for the structor variants, I am now using the complete variant to generate
> the names of the kernels as you suggested. I didn't add any method to CXXABI
> as that will require extra logic in ASTContext to
sfantao added a comment.
In http://reviews.llvm.org/D12614#278101, @rjmccall wrote:
> In http://reviews.llvm.org/D12614#274349, @sfantao wrote:
>
> > Hi John,
> >
> > Thanks for the remark!
> >
> > In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
> >
> > > CurFuncDecl is supposed to be
sfantao updated this revision to Diff 39588.
sfantao added a comment.
Use `CurFuncDecl` to generate offload kernel names as suggested by John McCall.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/
rjmccall added a comment.
In http://reviews.llvm.org/D12614#274349, @sfantao wrote:
> Hi John,
>
> Thanks for the remark!
>
> In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
>
> > CurFuncDecl is supposed to be the enclosing user function. Things like
> > outlined functions should be
sfantao added a comment.
Hi John,
Thanks for the remark!
In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
> CurFuncDecl is supposed to be the enclosing user function. Things like
> outlined functions should be getting stored in CurCodeDecl; that's how it's
> done for blocks and lam
rjmccall added a comment.
CurFuncDecl is supposed to be the enclosing user function. Things like
outlined functions should be getting stored in CurCodeDecl; that's how it's
done for blocks and lambdas.
http://reviews.llvm.org/D12614
___
cfe-commi
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962
@@ +1961,3 @@
+[LineNum][ColNum];
+assert(Entry.Order != -1u && "Entry not initialized!");
+assert(!Entry.Addr && !Entry.ID && "Entry registered alre
sfantao updated this revision to Diff 37802.
sfantao added a comment.
Use `GlobalDecl` to forward information about the name of OpenMP region's
enclosing function to the OpenMP outlined functions. This replaces the initial
implementation that was using a stack to keep this information.
Add regr
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962
@@ +1961,3 @@
+[LineNum][ColNum];
+assert(Entry.Order != -1u && "Entry not initialized!");
+assert(!Entry.Addr && !Entry.ID && "Entry registered alre
sfantao added a comment.
Ping!
http://reviews.llvm.org/D12614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Thanks for the comments!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
ABataev wrote:
> Maybe it is better to make it a class if it has some non-pu
sfantao updated this revision to Diff 36880.
sfantao added a comment.
Use class instead of structs if aggregate have private or protected fields.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/Lang
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
Maybe it is better to make it a class if it has some non-public members?
http://reviews.llvm.or
sfantao updated this revision to Diff 36812.
sfantao added a comment.
Rebase and fix typo in regression test directive.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/clang/
sfantao updated this revision to Diff 36410.
sfantao added a comment.
Fix bug for when no offloading triples are specified.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/cl
sfantao updated the summary for this revision.
sfantao updated this revision to Diff 34955.
sfantao added a comment.
Rebase on top of last changes in http://reviews.llvm.org/D12871.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOp
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel, tra.
sfantao added a subscriber: cfe-commits.
In order to offloading work properly two things need to be in place:
- a descriptor with all the offloading information (device entry functions, and
global variable) h
24 matches
Mail list logo
