This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
hctim marked an inline comment as done.
Closed by commit rG8db981d463ee: Add sanitizer-specific GlobalValue attributes.
(authored by hctim).
Repository:
rG LLVM Gith
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1389
+
+ if (GV.hasSanitizerMetadata())
+Vals.push_back(serializeSanitizerMetadata(GV.getSaniti
hctim updated this revision to Diff 435219.
hctim marked 5 inline comments as done.
hctim added a comment.
Update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
llvm/include/llvm/AsmParser/LLPa
hctim marked 5 inline comments as done.
hctim added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:397
+ // GV's mentioned in -fsanitize-ignorelist=.
+ kw_no_sanitize,
+ // GV's with __attribute__((no_sanitize("address"))).
vitalybuka wrote
vitalybuka updated this revision to Diff 434955.
vitalybuka added a comment.
fix rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
llvm/include/llvm/AsmParser/LLParser.h
llvm/include/llvm/
vitalybuka updated this revision to Diff 434947.
vitalybuka added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/lib/CodeGen/Sanitiz
vitalybuka added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:397
+ // GV's mentioned in -fsanitize-ignorelist=.
+ kw_no_sanitize,
+ // GV's with __attribute__((no_sanitize("address"))).
do we need no_sanitize on IR level?
We should map i
vitalybuka added inline comments.
Comment at: llvm/include/llvm/IR/GlobalValue.h:329
+}
+void deserialize(unsigned V) {
+ if (V & (1 << 0)) NoSanitize = true;
vitalybuka wrote:
> serialization should not be in this header, this bit stuff is /Bitcode/
hctim added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:181
#define GET_ATTR_NAMES
#define ATTRIBUTE_ENUM(ENUM_NAME, DISPLAY_NAME) \
kw_##DISPLAY_NAME,
vitalybuka wrote:
> Have you considered in Attributes.inc ?
>
> /// Can be used as
hctim updated this revision to Diff 434618.
hctim marked 5 inline comments as done.
hctim added a comment.
Update w/ Vitaly's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
llvm/includ
vitalybuka added a comment.
LGTM, with Asm test and bitcode stuff moved as explained.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
___
cfe-commits mailing li
vitalybuka added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:181
#define GET_ATTR_NAMES
#define ATTRIBUTE_ENUM(ENUM_NAME, DISPLAY_NAME) \
kw_##DISPLAY_NAME,
Have you considered in Attributes.inc ?
/// Can be used as global attribute.
hctim updated this revision to Diff 434228.
hctim marked 4 inline comments as done.
hctim added a comment.
Update from Vitaly's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
llvm/incl
hctim marked 7 inline comments as done.
hctim added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:429
+ // Extra sanitizer attributes that are used for global variables (GV's).
+ // GV's mentioned in -fsanitize-ignorelist=.
+ kw_no_sanitize,
--
vitalybuka added inline comments.
Comment at: llvm/include/llvm/AsmParser/LLToken.h:429
+ // Extra sanitizer attributes that are used for global variables (GV's).
+ // GV's mentioned in -fsanitize-ignorelist=.
+ kw_no_sanitize,
it should be next to other kw_ s
hctim added a comment.
Also, the bitset now doesn't have positive-inclusions for ASan/HWASan, and no
mention of MTE yet (which will come later). Sanitizers are applied to all GVs
implicitly, so we only need to carry around the exclude masks. Added a comment
to the struct that clarifies this.
hctim updated this revision to Diff 433889.
hctim marked an inline comment as done.
hctim added a comment.
Add round-trip tests, fork out the clang and langref changes for further
commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
vitalybuka requested changes to this revision.
vitalybuka added a comment.
This revision now requires changes to proceed.
all stuff under llvm/... here needs testing, Bitcode and AsmParser have many
tests usable as examples
Also probably better to separate from clang changes:
Patch 1: extends LL
kstoimenov accepted this revision.
kstoimenov added a comment.
This revision is now accepted and ready to land.
LGTM, but get one from vitalybuka@ too.
Sorry about delayed review, I missed it. Next time ping me if I don't respond
within a day.
Comment at: llvm/lib/IR/Globals.
hctim added a comment.
(friendly ping)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
hctim updated this revision to Diff 431810.
hctim added a comment.
Remove extra creation path, turns out it's a duplicate of elsewhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://reviews.llvm.org/D126100
Files:
clang/lib/C
hctim updated this revision to Diff 431508.
hctim added a comment.
Add an extra Global creation path from the frontend, and fix up a comment from
Kirill on the other revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126100/new/
https://revie
hctim created this revision.
hctim added reviewers: vitalybuka, kstoimenov.
Herald added subscribers: ormris, jdoerfert, steven_wu, hiraditya.
Herald added a project: All.
hctim requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commit
23 matches
Mail list logo
