[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. @arphaman Thanks for the quick action. The tests pass on a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/1493, so that's probably why there was trouble reproducing. I think we could revert 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://review

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan I'm going to disable these tests for `aix` for now to unblock the bot as they're still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 _

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of `index-concept-kind.cpp` does not have any concepts output:

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Sure, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

Jake-Egan added a comment. Hi, these tests fail on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/1489 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee8524087c78: [libclang] add supporting for indexing/visiting C++ concepts (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan accepted this revision. egorzhdan added a comment. This revision is now accepted and ready to land. I'm not super familiar with concepts but this LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman updated this revision to Diff 431506. arphaman added a comment. Herald added a project: clang. Fix the windows test failure (add -fno-delayed-template-parsing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Yes, I'm going to check what's wrong with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan added a comment. Looks like `index-concepts.cpp` is failing on Windows, @arphaman could you please take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman created this revision. arphaman added reviewers: egorzhdan, jansvoboda11, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. arphaman requested review of this revision. This patch builds upon recently added indexing support for C++ concepts from https://reviews.l