steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125974/new/
https://reviews.llvm.org/D125974
MichielDerhaeg updated this revision to Diff 431768.
MichielDerhaeg marked an inline comment as done.
MichielDerhaeg added a comment.
- add target requirement to lit test
- move condition
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125974/new/
ht
wanders added a comment.
This looks sensible to me. But I'm not an expert in the area (and still not
100% clear on the purpose of the ignorelist) so can't really say if the added
comments captures the intent accurately.
Comment at: clang/test/Driver/embed-bitcode-elf.c:1
+//
MichielDerhaeg marked an inline comment as done.
MichielDerhaeg added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762
// reject options that shouldn't be supported in bitcode
// also reject kernel/kext
static const constexpr unsigned kB
MichielDerhaeg updated this revision to Diff 431479.
MichielDerhaeg added a comment.
Herald added a reviewer: alexander-shaposhnikov.
- Render options for other platforms and test
- comment and propagate list
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
wanders added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4760-4762
// reject options that shouldn't be supported in bitcode
// also reject kernel/kext
static const constexpr unsigned kBitcodeOptionIgnorelist[] = {
This comme
steven_wu added a comment.
LGTM. Can you add a test for your usecase?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125974/new/
https://reviews.llvm.org/D125974
___
cfe-commits mailing list
cfe-commits@l
