[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-19 Thread Wang Pengcheng via Phabricator via cfe-commits
pcwang-thead added a comment. In D125947#3525539 , @jrtc27 wrote: > Also, the tests where you have codegen changes rather than preserving a > soft-float ABI should probably be put up for review separately by adding an > explicit hard single-float ABI, a

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-19 Thread Wang Pengcheng via Phabricator via cfe-commits
pcwang-thead added a comment. In D125947#3525537 , @jrtc27 wrote: > It's currently this way in order to be compatible with GCC. Changing this > requires consensus from both toolchains to ensure compatibility is preserved. > See https://github.com/riscv-

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-19 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Also, the tests where you have codegen changes rather than preserving a soft-float ABI should probably be put up for review separately by adding an explicit hard single-float ABI, as those seem worthwhile for reducing noise Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-19 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. It's currently this way in order to be compatible with GCC. Changing this requires consensus from both toolchains to ensure compatibility is preserved. See https://github.com/riscv-non-isa/riscv-toolchain-conventions/issues/13 for some discussion on this. Repository:

[PATCH] D125947: [RISCV] Add default ABI for archs with only F extension

2022-05-18 Thread Wang Pengcheng via Phabricator via cfe-commits
pcwang-thead created this revision. pcwang-thead added reviewers: asb, craig.topper, benshi001, luismarques, jrtc27. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, bruceh