[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464649. Purva-Chaudhari added a comment. check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/In

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464628. Purva-Chaudhari added a comment. remove white space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464623. Purva-Chaudhari added a comment. fix test and clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 464159. Purva-Chaudhari added a comment. rebase, test passing locally CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalPar

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari added a comment. In D125944#3689022 , @v.g.vassilev wrote: > @Purva-Chaudhari can you rebase this patch? In D125944#3821679 , @aaron.ballman wrote: > The precommit CI failure looks relevant:

[PATCH] D125944: Template instantiation error recovery

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. The precommit CI failure looks relevant: TEST 'Clang :: Interpreter/template-recovery.cpp' FAILED Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/build

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. This looks reasonable to me but let's have another pair of eyes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___ cfe-co

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 449059. Purva-Chaudhari added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/I

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 448977. Purva-Chaudhari added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/test/I

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari added a comment. In D125944#3689022 , @v.g.vassilev wrote: > @Purva-Chaudhari can you rebase this patch? Yes. I realized I would have to rebase Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 Diagnostic

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. @Purva-Chaudhari can you rebase this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 441089. Purva-Chaudhari added a comment. add preamble to test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 441079. Purva-Chaudhari added a comment. Updating CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp Index: cla

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 440980. Purva-Chaudhari added a comment. File name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cpp clang/tes

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 440959. Purva-Chaudhari added a comment. Added new file for template test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/Incrementa

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. In D125944#3544341 , @v.g.vassilev wrote: > @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. > > @rsmith, we need to do something similar in cling to handle pending template > instantiations, I g

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. @rsmith, we need to do something similar in cling to handle pending template instantiations, I guess the ques

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari updated this revision to Diff 430579. Purva-Chaudhari added a comment. Shifted private member CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 Files: clang/include/clang/Sema/Sema.h clang/lib/Interpreter/IncrementalParser.cp

[PATCH] D125944: Template instantiation error recovery

Purva-Chaudhari created this revision. Purva-Chaudhari added a reviewer: v.g.vassilev. Herald added a project: All. Purva-Chaudhari requested review of this revision. If error was encountered after template instantiation, the clang-repl interactive mode was aborted. The patch adds recovery suppor