This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5bbf6ad5b64c: Add an option to fill container for ref
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125925/new/
https://reviews.llvm.org/D125925
__
usaxena95 updated this revision to Diff 430657.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125925/new/
https://reviews.llvm.org/D125925
Files:
clang-to
kadircet added a comment.
Can you also update the remote-index protos & marshalling logic in:
- clang-tools-extra/clangd/index/remote/Index.proto
- clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp
Comment at: clang-tools-extra/clangd/index/Index.h:75
llvm::
usaxena95 created this revision.
usaxena95 added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
This allows index implementations
