[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

2022-05-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. The intent here is that `user-defined-string-literal-chunk := STRING_LITERAL` only matches when there's a ud-suffix. And `string-literal-chunk := STRING_LITERAL` only matches when there isn't. (e.g. with a rule guard, which we don't have implemented) If this was happen

[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

2022-05-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx.bnf:716 string-literal := string-literal-chunk -string-literal := string-literal string-literal-chunk +string-literal := string-literal-chunk string-literal user-defined-literal := user-defined-integer-l

[PATCH] D125794: [pseudo] Remove unnecessary user-defined-string-literal rule.

2022-05-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. We accidently define two identical rules for user-defined-string-literal (one