steakhal abandoned this revision.
steakhal added a comment.
We don't have the consensus to make me confident in landing this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125749/new/
https://reviews.llvm.org/D125749
___
steakhal added a comment.
There is one minor problem with this patch.
At `SVal` member function's context one needs to call `llvm::isa<...>()` with
by the qualified name, otherwise, the `isa` is ambiguous.
The compiler won't know if we want to refer to the free-function or the
variadic member f
steakhal updated this revision to Diff 430326.
steakhal marked an inline comment as done.
steakhal edited the summary of this revision.
steakhal added a comment.
- Prefer `V.isUndef()` to `V.isa()`.
- Remove tautologically true assertions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
steakhal added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/ObjCAtSyncChecker.cpp:44
// Uninitialized value used for the mutex?
- if (V.getAs()) {
+ if (V.isa()) {
if (ExplodedNode *N = C.generateErrorNode()) {
xazax.hun wrote:
> Is th
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/ObjCAtSyncChecker.cpp:44
// Uninitialized value used for the mutex?
- if (V.getAs()) {
+ if (V.isa()) {
if (ExplodedNode *N = C.generateErrorNode()) {
Is there a difference b
bzcheeseman added a comment.
Not a qualified reviewer for anything other than the `llvm::isa` usage and that
line looks good to me!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125749/new/
https://reviews.llvm.org/D125749
___
steakhal updated this revision to Diff 429960.
steakhal added a comment.
Refactor in the `getAs` uses of `clang/include/StaticAnalyzer` directory as
well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125749/new/
https://reviews.llvm.org/D125749
steakhal added inline comments.
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:99-100
+ template bool isa() const { return llvm::isa(*this);
}
+
/// Convert to the specified SVal type, asserting that this SVal is of
This is the
steakhal created this revision.
steakhal added reviewers: NoQ, martong, Szelethus, balazske, ASDenysPetrov,
bzcheeseman, xazax.hun.
Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, rnkovacs, szepet, baloghadamsoftware.
Herald added a project: All.
steakhal requeste
