[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

2022-05-16 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + nickdesaulniers wrote: > Consider adding a test: > > ``` > // RUN: %clang_cc1 -fsyntax-only -verify %s

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

2022-05-16 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:484 const SourceLocation &EndLoc) const { + // If this is a `.S` file, treat unknown # directives as non-preprocessor + // directives. A

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

2022-05-16 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + Consider adding a test: ``` // RUN: %clang_cc1 -fsyntax-only -verify %s -x assembler-with-cpp < %s ```

[PATCH] D125727: Avoid suggesting typoed directives in `.S` files

2022-05-16 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui created this revision. ken-matsui added a reviewer: aaron.ballman. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is itended to avoid suggesting typoed directives in `.S` files