[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:181 +if (DAL->hasArg(options::OPT__SLASH_P)) + getDriver().Diag(diag::warn_drv_dxc_ignore_output_for_preprocess) << "Fo"; + python3kgae wrote: > beanz wrote: > > This warning

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa(JA) && !isa(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs()

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa(JA) && !isa(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) Why is

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457353. python3kgae added a comment. Update warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:670 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup; We should be specific about which

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457329. python3kgae added a comment. Make a full patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457313. python3kgae added a comment. Not need to send -P and -Fi to cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files: clang/include/clang/Basic/Diagno

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457191. python3kgae marked an inline comment as done. python3kgae added a comment. Switch to CLMode -P and -Fi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Fi

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6921 HelpText<"Entry point name">; +def dxc_P : Option<["--", "/", "-"], "P", KIND_SEPARATE>, + Group, Flags<[DXCOption, NoXarchOption]>, This is the same option

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 450377. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase and fix merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655

[PATCH] D125655: [HLSL] add -P option for dxc mode.

pow2clk added a comment. Mostly just some comments on user output Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup; ---

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M