[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

2022-05-19 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. In D125635#3514607 , @rjmccall wrote: > On the one hand, I'm not sure 8M statements in a block — or 1M, for that > matter — is an unreasonable implementation limit. On the other hand, this > patch looks like it only changes o

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

2022-05-19 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 430613. sepavloff added a comment. Move NumStmts back to CompoundStmtBitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125635/new/ https://reviews.llvm.org/D125635 Files: clang/include/clang/AST/Stmt

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

2022-05-15 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. On the one hand, I'm not sure 8M statements in a block — or 1M, for that matter — is an unreasonable implementation limit. On the other hand, this patch looks like it only changes overall memory use on 32-bit hosts, because `CompoundStmt` has a 32-bit field prior to i

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

2022-05-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: aaron.ballman, rsmith, rjmccall. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Number of statements in CompoundStmt is kept in a bit-field of Stmt common part. The field has 24 bi