[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

2022-07-11 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:488 + } + if (NewRM != llvm::RoundingMode::Dynamic) +Builder.CreateIntrinsic( aaron.ballman wrote: > I was imagining that if the new rounding mode is dynamic, we still need to > rese

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

2022-07-11 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 443606. sepavloff added a comment. Rebased and addressed reviever's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125625/new/ https://reviews.llvm.org/D125625 Files: clang/include/clang/Basic/Diag

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

2022-06-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: zahiraam. aaron.ballman added a comment. Thank you for working on this (and thank you for your patience with how long it's taken me to get to this review)! Adding another reviewer who has recently been poking at floating point environment pragmas in case Zahira h

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

2022-05-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, kpn, andrew.w.kaylor. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. This pragma is introduced by forthcoming C2x standard and can be used to set