[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. Committing this revealed some more failures, fixed in rG8894c05b0d351f998b1836542ba791247394bd12 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/n

[PATCH] D125604: [FileCheck] Catch missspelled directives.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad1d60c3befd: [FileCheck] Catch missspelled directives. (authored by kosarev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 431979. kosarev added a comment. Rebased on top of fixes for non-trivial cases. Going to submit this tomorrow, if no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.or

[PATCH] D125604: [FileCheck] Catch missspelled directives.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: bzcheeseman. LGTM. Thanks for pinging the relevant folks on individual tests. You can push the fixes yourself before landing this patch. Repository: rG LLVM Git

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430392. kosarev added a comment. Herald added a project: Flang. Added Flang fixes and rebased. Thanks Simon for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.l

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688 +; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h +; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h +; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]] +; TODO-CVT-DAG:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

dmgreen added inline comments. Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688 +; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h +; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h +; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]] +; TODO-CVT-DAG:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added subscribers: chill, momchil.velikov, az, alex-t, keith.walker.arm, plotfi, aivchenk, zer0, awanpand, levivic, zlei. kosarev added a comment. Tagging more people in hope to add visibility. Comment at: clang/test/CodeGen/cmse-clear-return.c:235 // CHECK-BE-NOPT-NE

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-template-parameter.ll:36 ; CHECK-NEXT: DW_AT_name {{.*}} "i" -; CHECK_NEXT: DW_AT_default_value {{.*}} true +; TODO-NEXT: DW_AT_default_value {{.*}} true Should be fixed by rGf718664

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added a comment. Thanks @kosarev - CodeGen\X86 should be clean now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 ___ cfe-commits mailing list cfe-com

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 430322. kosarev added a comment. Herald added a reviewer: bollu. Add Polly fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 Files: clang/test/CodeGen/cmse-cle

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 429997. kosarev added a comment. Herald added subscribers: ThomasRaoux, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, mravishankar, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb,

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); +

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest &Req, StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + i

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. In D125604#3514983 , @jhenderson wrote: > Are the TODO cases where the test fails if changing them? Yes, this and where the fix is not perfectly obvious. Comment at: llvm/test/FileCheck/missspelled-directive.

[PATCH] D125604: [FileCheck] Catch missspelled directives.

jhenderson added a comment. Code change looks good to me. Are the TODO cases where the test fails if changing them? Comment at: llvm/test/FileCheck/missspelled-directive.txt:18 + +P4_COUNT-2: foo +CHECK4: error: misspelled directive 'P4_COUNT-2:' What about `P

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. A work in progress. Contains changes that we likely want to see addressed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev created this revision. Herald added subscribers: mattd, gchakrabarti, pmatos, asb, asavonic, wenlei, kerbowa, pengfei, Jim, asbirlea, thopre, rupprecht, george.burgess.iv, kbarton, hiraditya, jgravelle-google, sbc100, jvesely, nemanjai, dylanmckay, dschuff, jholewinski. Herald added a re