[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG366e57de23ed: [clang-cl] Add /Zc:wchar_t- option (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added a comment. In D125513#3519200 , @thakis wrote: > Looks good to me after addressing Hans's comment. > > Do you have commit access? Thanks for asking, @thakis. I do have comment access. Repository:

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:50 // RUN: %clang_cl /c -### /Zc:wchar_t- -- %s 2>&1 | FileCheck -check-prefix=WCHAR_T-OFF %s -// WCHAR_T-OFF: argument unused during compilation +// WCHAR_T-OFF: "-fn

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng updated this revision to Diff 430096. pzheng marked an inline comment as done. pzheng added a comment. Address @hans's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://reviews.llvm.org/D125513 Files: clang/include

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Looks good to me after addressing Hans's comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

hans added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:50 // RUN: %clang_cl /c -### /Zc:wchar_t- -- %s 2>&1 | FileCheck -check-prefix=WCHAR_T-OFF %s -// WCHAR_T-OFF: argument unused during compilation +// WCHAR_T-OFF: "-fno-wchar" Should probably

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added inline comments. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">;

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng updated this revision to Diff 429559. pzheng added a comment. Address @thakis's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://reviews.llvm.org/D125513 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis added a comment. Seems generally ok. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">; Can you

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng created this revision. pzheng added reviewers: rnk, mstorsjo, thakis, hans. Herald added a project: All. pzheng requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Map /Zc:wchar_t- to the cc1 flag -fno-wchar which is already supp