[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-03 Thread Tommy Chiang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8df2b1a86680: [pp-trace] Print HashLoc in InclusionDirective callback (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https:

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-02 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT added a comment. Thanks for reviewing! I will commit it myself later. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-02 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT updated this revision to Diff 433722. oToToT added a comment. Added a release note for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-06-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Can you add a release note for the change? (There's an `Improvements to pp-trace` section in docs\ReleaseNotes.rst) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-05-26 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

2022-05-11 Thread Tommy Chiang via Phabricator via cfe-commits
oToToT created this revision. oToToT added reviewers: jtsoftware, klimek. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. oToToT requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The HashLoc in InclusionD