[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3e4727907e5: [HLSL] add -D option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.o

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 433227. python3kgae added a comment. Recover after fixed Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Op

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae reopened this revision. python3kgae added a comment. This revision is now accepted and ready to land. Reopen to recover the change after fix Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.ll

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae added a comment. In D125338#3507063 , @thakis wrote: > Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I'll revert it. Thanks. Repository:

[PATCH] D125338: [HLSL] add -D option for dxc mode.

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/35103/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dae38ebfba0: [HLSL] add -D option for dxc mode. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D125338?vs=428698&id

[PATCH] D125338: [HLSL] add -D option for dxc mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a super minor nit with the test. Comment at: clang/test/Driver/dxc_D.hlsl:14 +// ERROR-NOT: error: \ No newline at end of file You should add the newline back to the end of th

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 428698. python3kgae added a comment. Add check for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D125338: [HLSL] add -D option for dxc mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a testing suggestion. Comment at: clang/test/Driver/dxc_D.hlsl:5 +// CHECK:"-D" "TEST=2" + Maybe we should also test that the m

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk, aaron.ballman. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: