This revision was automatically updated to reflect the committed changes.
Closed by commit rG5189f634a113: [OpenMP] Don't include the device
wrappers if -nostdinc is used (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125265/new
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM in general.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1311
if (JA.isDeviceOffloading(Action::OFK_OpenMP) &&
+ !Args.hasArg(options::OPT_nostdlib) &&
(ge
jhuber6 updated this revision to Diff 428181.
jhuber6 added a comment.
Fix using `nostdlib` instead of `nostdinc`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125265/new/
https://reviews.llvm.org/D125265
Files:
clang/lib/Driver/ToolChains/Clang
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1311
if (JA.isDeviceOffloading(Action::OFK_OpenMP) &&
+ !Args.hasArg(options::OPT_nostdlib) &&
(getToolChain().getTriple().isNVPTX() ||
tra wrote:
> Did you mean `nost
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1311
if (JA.isDeviceOffloading(Action::OFK_OpenMP) &&
+ !Args.hasArg(options::OPT_nostdlib) &&
(getToolChain().getTriple().isNVPTX() ||
Did you mean `nostdinc` ?
Reposit
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev,
tra.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Herald add
