[PATCH] D125228: [clangd] Support for standard inlayHint protocol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3137ca80b9ef: [clangd] Support for standard inlayHint protocol (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428413. kadircet added a comment. - Default initialize paddingLeft/Right - Don't serialize kind when its null - Run in vscode, seems to be working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ htt

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! If you didn't already, can you check with VSCode before landing? This might catch protocol bits we missed, but also will make sure that the disablement of the legacy protocol in vs

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428370. kadircet added a comment. - Advertise inlayHintProvider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:586 + // Only advertise inlayHints extension if client doesn't support the standard + // implementation. sammccall wrote: > I still feel a little uncomfortable with this

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428368. kadircet marked 9 inline comments as done. kadircet added a comment. - Get rid of warning and not advertising when client has capability. - Introduce paddingLeft/paddingRight, get rid of leading/trailing spaces in label, but re-introduce them when se

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

sammccall added a comment. This looks like the right approach to me, thanks for doing this! What do you want to do about paddingLeft/paddingRight? IIUC where we're currently sending `label="foo: "` we need to send `label="foo:", paddingRight=true`. But updating these strings might have a blast r

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428089. kadircet added a comment. - Mention range as an extension field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPS

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428072. kadircet added a comment. - Add lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. -