[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe895d5768d5: [pseudo] Add benchmarks for pseudoparser. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125226/new/ https://reviews.llvm

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein added a comment. In D125226#3500691 , @sammccall wrote: > > I think we should have some fixed checked-in examples, but we can add them > later. Yeah, it is a good idea to have some fixed datasets checked in (but we will not run them in build

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:49 +static void runParseGrammar(benchmark::State &State) { + std::string GrammarText = readFile(GrammarFile); + for (auto _ : State) sammccall wrote: > rather than have

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein updated this revision to Diff 428323. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125226/new/ https://reviews.llvm.org/D125226 Files: clang-tools-extra/ps

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! This will be very useful. I think we should have some fixed checked-in examples, but we can add them later. BTW, the fuzzer identifies slow inputs, I have attached one (though it l

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Running on SemaDecl.cpp with the cxx.bnf g