[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:696-698 +def ext_c2x_pp_directive : Extension< + "%select{#elifdef|#elifndef}0 is a C2x extension">, + InGroup; aaron.ballman wrote: > ken-matsui wrote: > > aaron.ball

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:696-698 +def ext_c2x_pp_directive : Extension< + "%select{#elifdef|#elifndef}0 is a C2x extension">, + InGroup; ken-matsui wrote: > aaron.ballman wrote: > > ken-mat

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added a comment. In D125178#3503617 , @aaron.ballman wrote: > It looks like precommit CI caught some related failures: > > Failed Tests (7): > Clang :: Lexer/deprecate-macro.c > Clang :: Lexer/unsafe-macro.c > Clang :: Preprocess

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. It looks like precommit CI caught some related failures: Failed Tests (7): Clang :: Lexer/deprecate-macro.c Clang :: Lexer/unsafe-macro.c Clang :: Preprocessor/elifdef.c Clang :: Preprocessor/if_warning.c Clang :: Preprocessor/ifdef-recover.c

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui added a comment. Thank you so much for your review! Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:696-698 +def ext_c2x_pp_directive : Extension< + "%select{#elifdef|#elifndef}0 is a C2x extension">, + InGroup; aaron.ballman wrote: > I

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-10 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui updated this revision to Diff 428358. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for working on this! Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:696-698 +def ext_c2x_pp_directive : Extension< + "%select{#elifdef|#elifndef}0 is a C2x extension">, + InGroup; I think we need two diagn

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x mode

2022-05-07 Thread Ken Matsui via Phabricator via cfe-commits
ken-matsui created this revision. ken-matsui added a reviewer: aaron.ballman. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch resolves https://github.com/llvm/llvm-project/issues/55306. R