[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1545f51a9ef: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode (authored by ken-matsui, committed by aaron.ballman). Changed prior to co

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. I fixed it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428910. ken-matsui added a comment. Fix the failed test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

aaron.ballman added a comment. Oops, it looks like precommit CI found a relevant issue, can you fix it up? Failed Tests (1): Clang :: Preprocessor/elifdef.c Testing Time: 790.67s Skipped :56 Unsupported : 1997 Passed : 87720 Expectedly Fail

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. Thank you so much for your review! My public email address is: `07softy_br...@icloud.com`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428840. ken-matsui added a comment. Updated the code as reviewed, added a release note, and merged `ext-cpp2b-pp-directive.cpp` & `ext-c2x-pp-directive.c` into `ext-pp-directive.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a super minor nit in a test file. Can you please add a release note for the new diagnostics as well? I'm happy to land this for you when you're ready, but let me

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui added a comment. Thank you for your review! I updated the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 ___ cfe-commits mailing list cfe-comm

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428636. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKin

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:698 +def warn_c2x_compat_pp_directive : Warning< + "use of a '#%select{elifdef|elifndef}0' directive is incompatible with C standards before C2x">, + InGroup, DefaultIgnore; --

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428435. ken-matsui added a comment. Fix failed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKinds.td cla