[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

2022-05-09 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGbf9921adb930: [clangd] Disable predefined macros in tests. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D125172?vs=427875&id

[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

2022-05-09 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:44 + // In tests, we don't need predefined macros (__GNUC__, __CHAR_BIT__) etc. + // There are

[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

2022-05-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.