[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

2022-05-06 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D125092#3497033 , @saiislam wrote: >> Ideally we could just put this on the linker itself, but nvlink doesn't seem >> to support .a files. > > Yes, nvlink does not support archives. So we used a wrapper to extract cubin > fil

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

2022-05-06 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. > Ideally we could just put this on the linker itself, but nvlink doesn't seem > to support .a files. Yes, nvlink does not support archives. So we used a wrapper to extract cubin files from the archive and pass them to nvlink. Please see, Clang Nvlink Wrapper

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

2022-05-06 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe12905b4d5f9: [OpenMP] Add basic support for properly handling static libraries (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D125092?vs=427618&id=427646#toc Repository: rG

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

2022-05-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Typo(s) in the commit message, otherwise this seems reasonable. LG Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1153 + for (auto &File : Library

[PATCH] D125092: [OpenMP] Add basic support for properly handling static libraries

2022-05-06 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Cu