[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet closed this revision. kadircet added a comment. Landed as rG9fe89a1f0fa6d88aa4786580b89e81dc906fcc52 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 __

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-09 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. In D125088#3499649 , @nridge wrote: > Is there a related change that explains what this setting does? Yes: https://reviews.llvm.org/D123488 It seems that I forgot to add the YAML parser logic :( CHANGES SINCE LAST ACTION ht

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Is there a related change that explains what this setting does? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-06 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); kbobyr

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-06 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); A ==

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e