This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG85ec8a9ac141: [clang-format] Correctly handle
SpaceBeforeParens for builtins. (authored by curdeius).
Repository:
rG LLVM Github Monorepo
CHANGES
owenpan accepted this revision.
owenpan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125085/new/
https://reviews.llvm.org/D125085
_
curdeius updated this revision to Diff 428009.
curdeius marked an inline comment as done.
curdeius added a comment.
Address comment: simplify.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125085/new/
https://reviews.llvm.org/D125085
Files:
clan
owenpan added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:3439-3441
+(Left.is(tok::identifier) || Left.Tok.getIdentifierInfo() ||
+ Left.isFunctionLikeKeyword() || Left.is(tok::r_paren) ||
+ Left.isSimpleTypeSpecifier()))
-
urnathan added a comment.
cool
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125085/new/
https://reviews.llvm.org/D125085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
curdeius created this revision.
curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan.
Herald added a project: All.
curdeius requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
That's a partial fix for https://github.com/llvm/ll
